Allow using default gRPC dialer #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejholly
approved these changes
May 15, 2024
brandonSc
force-pushed
the
brandon/http-proxy
branch
from
aa9afed
to
3d49f90
Compare
|
Corresponding earthly PR earthly/earthly#4115 |
brandonSc
force-pushed
the
brandon/http-proxy
branch
from
3d49f90
to
a7a496a
Compare
Buildkit has a custom `resolveDialer` dailer, that does not support HTTP proxy. This adds the ability for a client to enable the default gRPC dialer, which allows support for HTTP.
brandonSc
force-pushed
the
brandon/http-proxy
branch
from
a7a496a
to
e163acd
Compare
alexcb
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin dialer in gRPC has support for things like HTTP connect proxy which we need to support BYOC satellites in some environments. Buildkit was previously forcing it's own dialer implementation.